payne8/docbox
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Don't abuse the title attribute

Browse Source
This commit is contained in:
Tom MacWright
2016-03-03 13:29:47 -08:00
parent bd1d4b2b25
commit e90ffea98b
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/components/app.js
View File

@ -79,7 +79,7 @@ var App = React.createClass({
var rect = sections[i].getBoundingClientRect(); var rect = sections[i].getBoundingClientRect();
if (rect.bottom > 0) { if (rect.bottom > 0) {
this.setState({ this.setState({
activeSection: sections[i].title activeSection: sections[i].getAttribute('data-title')
}); });
return; return;
} }

2
src/components/section.js
View File

@ -27,7 +27,7 @@ var Section = React.createClass({
let { chunk } = this.props; let { chunk } = this.props;
let { left, right, preview } = chunk; let { left, right, preview } = chunk;
return (<div return (<div
title={chunk.title} data-title={chunk.title}
className={`section pad2y contain clearfix ${preview ? 'preview' : ''}`}> className={`section pad2y contain clearfix ${preview ? 'preview' : ''}`}>
<div <div
className='col6 pad2x prose clip' className='col6 pad2x prose clip'